andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Optimize IntObjectHashMap handling of negative keys.

Browse Source 
Motivation:

The hashIndex method currently uses a conditional to handle negative
keys. This could be done without a conditional to slightly improve
performance.

Modifications:

Modified hashIndex() to avoid using a conditional.

Result:

Slight performance improvement to hashIndex().
This commit is contained in:
nmittler 2014-10-20 10:19:54 -07:00
parent f9706fda42
commit bb397c183b
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/src/main/java/io/netty/util/collection/IntObjectHashMap.java
View File

@ -312,11 +312,9 @@ public class IntObjectHashMap<V> implements IntObjectMap<V>, Iterable<IntObjectM
* Returns the hashed index for the given key.
*/
private int hashIndex(int key) {
int hash = key % keys.length;
if (hash < 0) {
hash += keys.length;
}
return hash;
int length = keys.length;
// Allowing for negative keys by adding the length after the first mod operation.
return (key % length + length) % length;
}
/**