andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Scoring loopback addresses as 0 in DefaultChannelId

Browse Source 
Motivation:

As described in #3490, [compareAddresses](https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/DefaultChannelId.java#L182)  seems to allow loopback addresses to score high, disallowing replacing the loopback address.

Modifications:

Changed [scoreAddress](https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/DefaultChannelId.java#L283) to score loopback addresses as 0.

Result:

Fixes #3490
This commit is contained in:
nmittler 2015-05-08 08:04:25 -07:00
parent a2cd01b32b
commit bb5f9fe078
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/channel/DefaultChannelId.java
View File

@ -280,7 +280,7 @@ final class DefaultChannelId implements ChannelId {
}
private static int scoreAddress(InetAddress addr) {
if (addr.isAnyLocalAddress()) {
if (addr.isAnyLocalAddress() || addr.isLoopbackAddress()) {
return 0;
}
if (addr.isMulticastAddress()) {