andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not create an iterator unnecessarily

Browse Source
This commit is contained in:
Trustin Lee 2012-05-25 06:30:30 -07:00
parent 59f11ed64f
commit bc5e8b6be1
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
transport/src/main/java/io/netty/channel/socket/nio/SingleThreadSelectorEventLoop.java
View File

@ -163,8 +163,12 @@ final class SingleThreadSelectorEventLoop extends SingleThreadEventLoop {
} }
private void processSelectedKeys() { private void processSelectedKeys() {
Set<SelectionKey> selectedKeys = selector.selectedKeys();
if (selectedKeys.isEmpty()) {
return;
}
Iterator<SelectionKey> i; Iterator<SelectionKey> i;
for (i = selector.selectedKeys().iterator(); i.hasNext();) { for (i = selectedKeys.iterator(); i.hasNext();) {
final SelectionKey k = i.next(); final SelectionKey k = i.next();
i.remove(); i.remove();
final Channel ch = (Channel) k.attachment(); final Channel ch = (Channel) k.attachment();
@ -190,7 +194,11 @@ final class SingleThreadSelectorEventLoop extends SingleThreadEventLoop {
if (cleanUpCancelledKeys()) { if (cleanUpCancelledKeys()) {
// Create the iterator again to avoid ConcurrentModificationException // Create the iterator again to avoid ConcurrentModificationException
i = selector.selectedKeys().iterator(); if (selectedKeys.isEmpty()) {
break;
} else {
i = selectedKeys.iterator();
}
} }
} }
} }