andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make ChannelGroup.write(..) retain the message

Browse Source
This commit is contained in:
Trustin Lee 2013-02-10 14:02:43 +09:00
parent 2f1a0b0593
commit bd0729ac45
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java
View File

@ -15,7 +15,7 @@
*/
package io.netty.channel.group;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.BufUtil;
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelFutureListener;
@ -207,18 +207,17 @@ public class DefaultChannelGroup extends AbstractSet<Channel> implements Channel
@Override
public ChannelGroupFuture write(Object message) {
Map<Integer, ChannelFuture> futures =
new LinkedHashMap<Integer, ChannelFuture>(size());
if (message instanceof ByteBuf) {
ByteBuf buf = (ByteBuf) message;
for (Channel c: nonServerChannels.values()) {
futures.put(c.id(), c.write(buf.duplicate()));
}
} else {
for (Channel c: nonServerChannels.values()) {
futures.put(c.id(), c.write(message));
}
if (message == null) {
throw new NullPointerException("message");
}
Map<Integer, ChannelFuture> futures = new LinkedHashMap<Integer, ChannelFuture>(size());
for (Channel c: nonServerChannels.values()) {
BufUtil.retain(message);
futures.put(c.id(), c.write(message));
}
BufUtil.release(message);
return new DefaultChannelGroupFuture(this, futures);
}