andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Enforce a release is made with JDK 1.7 (and not w/ 1.8+)

Browse Source 
Motivations:

JDK 1.8 adds default methods to collections classes that reference
classes that don't exist in JDK 7. That's binary compatible,
but not source compatible.

Modifications:

Enforce JDK version to be 1.7.* when releasing

Result:

Fixes #3548
This commit is contained in:
Trustin Lee 2015-03-29 16:58:50 +09:00
parent ab74dccd23
commit bdf0bddc85
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pom.xml
View File

@ -216,6 +216,11 @@
</goals> </goals>
<configuration> <configuration>
<rules> <rules>
<requireJavaVersion>
<!-- Enforce JDK 1.7 (and not 1.8+) for compilation. -->
<!-- See: https://github.com/netty/netty/issues/3548 -->
<version>[1.7.0, 1.8.0)</version>
</requireJavaVersion>
<requireProperty> <requireProperty>
<regexMessage> <regexMessage>
Release process must be performed on linux-x86_64. Release process must be performed on linux-x86_64.
@ -877,8 +882,8 @@
<configuration> <configuration>
<rules> <rules>
<requireJavaVersion> <requireJavaVersion>
<!-- Enforce java 1.7 as minimum for compiling --> <!-- Enforce JDK 1.7+ for compilation. -->
<!-- This is needed because of java.util.zip.Deflater and NIO UDP multicast--> <!-- This is needed because of java.util.zip.Deflater and NIO UDP multicast. -->
<version>[1.7.0,)</version> <version>[1.7.0,)</version>
</requireJavaVersion> </requireJavaVersion>
<requireMavenVersion> <requireMavenVersion>