From bf5960e9eb08396b7fdf17aad963f5e0c4dd1557 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Tue, 11 Jun 2013 00:57:23 +0900 Subject: [PATCH] Fix #1435 and #1436 by reverting 7f7bf304b0b43a1445e68c15ee6f6403c7ca5b9e Different PooledByteBufs can have the reference to the same PooledChunk (and its ByteBuffer), so it's incorrect not to create a duplicate. --- .../main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java b/buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java index 01b113c98c..561539d374 100644 --- a/buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java @@ -71,7 +71,7 @@ final class PooledUnsafeDirectByteBuf extends PooledByteBuf { @Override protected ByteBuffer newInternalNioBuffer(ByteBuffer memory) { - return memory; + return memory.duplicate(); } @Override