andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add default block in AbstractDnsMessage (#11327)

Browse Source 
Motivation:

Every switch block should also have a default case.

Modification:

Add default block in AbstractDnsMessage to ensure we not fall-through by mistake

Result:

Cleanup

Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
This commit is contained in:
skyguard1 2021-05-28 14:49:18 +08:00 committed by GitHub
parent cfe631ad05
commit c098b48692
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codec-dns/src/main/java/io/netty/handler/codec/dns/AbstractDnsMessage.java
View File

@ -427,6 +427,8 @@ public abstract class AbstractDnsMessage extends AbstractReferenceCounted implem
return authorities; return authorities;
case 3: case 3:
return additionals; return additionals;
default:
break;
} }
throw new Error(); // Should never reach here. throw new Error(); // Should never reach here.
@ -446,6 +448,8 @@ public abstract class AbstractDnsMessage extends AbstractReferenceCounted implem
case 3: case 3:
additionals = value; additionals = value;
return; return;
default:
break;
} }
throw new Error(); // Should never reach here. throw new Error(); // Should never reach here.