From c13908adb5a90869338dece42b893e373acc364d Mon Sep 17 00:00:00 2001 From: Dmitriy Dumanskiy Date: Wed, 3 Aug 2016 23:28:44 +0300 Subject: [PATCH] deprecated old loggers Motivation: Commons logger is dead and not updated for more than 2 years. #5615. Modifications: Added @Deprecated annotation to CommonsLoggerFactory and CommonsLogger. Result: Commons logger now deprecated. --- .../java/io/netty/util/internal/logging/CommonsLogger.java | 4 ++++ .../netty/util/internal/logging/CommonsLoggerFactory.java | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java b/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java index 1068005e89..110f0f1cf9 100644 --- a/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java +++ b/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java @@ -44,7 +44,11 @@ import org.apache.commons.logging.Log; /** * Apache Commons Logging * logger. + * + * @deprecated Please use {@link Log4J2Logger} or {@link Log4JLogger} or + * {@link Slf4JLogger}. */ +@Deprecated class CommonsLogger extends AbstractInternalLogger { private static final long serialVersionUID = 8647838678388394885L; diff --git a/common/src/main/java/io/netty/util/internal/logging/CommonsLoggerFactory.java b/common/src/main/java/io/netty/util/internal/logging/CommonsLoggerFactory.java index 3e9ab9fafd..2b4af9f4e9 100644 --- a/common/src/main/java/io/netty/util/internal/logging/CommonsLoggerFactory.java +++ b/common/src/main/java/io/netty/util/internal/logging/CommonsLoggerFactory.java @@ -18,14 +18,15 @@ package io.netty.util.internal.logging; import org.apache.commons.logging.LogFactory; -import java.util.HashMap; -import java.util.Map; - /** * Logger factory which creates an * Apache Commons Logging * logger. + * + * @deprecated Please use {@link Log4J2LoggerFactory} or {@link Log4JLoggerFactory} or + * {@link Slf4JLoggerFactory}. */ +@Deprecated public class CommonsLoggerFactory extends InternalLoggerFactory { public static final InternalLoggerFactory INSTANCE = new CommonsLoggerFactory();