andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2363] Correctly null out SelectionKey[] when selectAgain

Browse Source 
Motivation:

The prefix fix of #2363 did not correctly handle the case when selectAgain is true and so missed to null out entries.

Modifications:

Move the i++ from end of loop to beginning of loop

Result:

Entries in the array will be null out so allow to have these GC'ed once the Channel close
This commit is contained in:
fu.jian 2016-01-08 14:11:58 +08:00 committed by Norman Maurer
parent b95dbb391f
commit c2c0d01ddb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
View File

@ -476,11 +476,11 @@ public final class NioEventLoop extends SingleThreadEventLoop {
// null out entries in the array to allow to have it GC'ed once the Channel close // null out entries in the array to allow to have it GC'ed once the Channel close
// See https://github.com/netty/netty/issues/2363 // See https://github.com/netty/netty/issues/2363
for (;;) { for (;;) {
i++;
if (selectedKeys[i] == null) { if (selectedKeys[i] == null) {
break; break;
} }
selectedKeys[i] = null; selectedKeys[i] = null;
i++;
} }
selectAgain(); selectAgain();