andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* Fixed incorrect SslHandler.context() implementation

Browse Source 
* Added some FIXMEs
This commit is contained in:
Trustin Lee 2009-10-21 03:58:38 +00:00
parent 5cfaf7333c
commit c3a88d0c48
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/org/jboss/netty/handler/ssl/SslHandler.java
View File

@ -306,6 +306,7 @@ public class SslHandler extends FrameDecoder implements ChannelDownstreamHandler
* succeeds or fails.
*/
public ChannelFuture handshake(Channel channel) throws SSLException {
// FIXME do not throw SSLException - return a failed future.
ChannelFuture handshakeFuture;
synchronized (handshakeLock) {
if (handshaking) {
@ -327,13 +328,14 @@ public class SslHandler extends FrameDecoder implements ChannelDownstreamHandler
* destroys the underlying {@link SSLEngine}.
*/
public ChannelFuture close(Channel channel) throws SSLException {
// FIXME do not throw SSLException - return a failed future.
ChannelHandlerContext ctx = context(channel);
engine.closeOutbound();
return wrapNonAppData(ctx, channel);
}
private ChannelHandlerContext context(Channel channel) {
return channel.getPipeline().getContext(getClass());
return channel.getPipeline().getContext(this);
}
public void handleDownstream(