andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#662] Fix race in AioEventLoopGroup

Browse Source 
- Fix a bug where shutdown() blocks indefinitely sometimes
This commit is contained in:
Trustin Lee 2012-10-23 16:09:59 -07:00
parent c38c1d0e6f
commit c43b9b4dd2
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
transport/src/main/java/io/netty/channel/socket/aio/AioEventLoopGroup.java
View File

@ -78,7 +78,11 @@ public class AioEventLoopGroup extends MultithreadEventLoopGroup {
boolean interrupted = false; boolean interrupted = false;
// Tell JDK not to accept any more registration request. Note that the threads are not really shut down yet. // Tell JDK not to accept any more registration request. Note that the threads are not really shut down yet.
group.shutdown(); try {
group.shutdownNow();
} catch (IOException e) {
throw new EventLoopException("failed to shut down a channel group", e);
}
// Wait until JDK propagates the shutdown request on AsynchronousChannelGroup to the ExecutorService. // Wait until JDK propagates the shutdown request on AsynchronousChannelGroup to the ExecutorService.
// JDK will probably submit some final tasks to the ExecutorService before shutting down the ExecutorService, // JDK will probably submit some final tasks to the ExecutorService before shutting down the ExecutorService,