andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleanup Http2MultiplexCodec by removing out-dated TODO

Browse Source 
Motivation:

Http2MultiplexCodec contains some TODO that is outdated.

Modifications:

Remove TODO which is outdated

Result:

Cleaner code.
This commit is contained in:
Norman Maurer 2018-01-26 15:53:33 +01:00
parent 9ba942e59b
commit c43dc3364b
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
View File

@ -155,9 +155,6 @@ public class Http2MultiplexCodec extends Http2FrameCodec {
private final ChannelHandler inboundStreamHandler;
private int initialOutboundStreamWindow = Http2CodecUtil.DEFAULT_WINDOW_SIZE;
// TODO: We may be able to optimize when we really need to call flush(...) during channelReadComplete(...)
// by checking if this is true and only then call flush(...).
private boolean flushNeeded;
private boolean parentReadInProgress;
private int idCount;
@ -376,18 +373,10 @@ public class Http2MultiplexCodec extends Http2FrameCodec {
tail = head = null;
// We always flush as this is what Http2ConnectionHandler does for now.
// TODO: I think this is not really necessary and we should be able to optimize this in the future by
// checking flushNeeded and only flush if this returns true.
flush0(ctx);
}
}
@Override
public final void flush(ChannelHandlerContext ctx) {
flushNeeded = false;
super.flush(ctx);
}
// Allow to override for testing
void flush0(ChannelHandlerContext ctx) {
flush(ctx);
@ -768,10 +757,8 @@ public class Http2MultiplexCodec extends Http2FrameCodec {
unsafe().recvBufAllocHandle().readComplete();
pipeline().fireChannelReadComplete();
}
flushNeeded |= flushPending;
} finally {
inFireChannelReadComplete = false;
flushPending = false;
}
}