andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Optimize ReplayingDecoder even further

Browse Source 
* If checkpoint is non-zero, do not copy the whole input into cumulation but copy only the part after the checkpoint
This commit is contained in:
Trustin Lee 2012-02-29 09:40:34 -08:00
parent 8ab9451086
commit c46593266d
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
codec/src/main/java/io/netty/handler/codec/replay/ReplayingDecoder.java
View File

@ -445,18 +445,24 @@ public abstract class ReplayingDecoder<T extends Enum<T>>
// seems like there is something readable left in the input buffer
// or decoder wants a replay - create the cumulation buffer and
// copy the input into it
if (checkpoint >= 0) {
ChannelBuffer cumulation = this.cumulation =
ChannelBuffer cumulation;
if (checkpoint > 0) {
int bytesToPreserve = inputSize - (checkpoint - oldReaderIndex);
cumulation = this.cumulation =
newCumulationBuffer(ctx, bytesToPreserve);
cumulation.writeBytes(input, checkpoint, bytesToPreserve);
} else if (checkpoint == 0) {
cumulation = this.cumulation =
newCumulationBuffer(ctx, inputSize);
cumulation.writeBytes(input, oldReaderIndex, inputSize);
cumulation.readerIndex(input.readerIndex());
replayable = new ReplayingDecoderBuffer(cumulation);
} else {
ChannelBuffer cumulation = this.cumulation =
cumulation = this.cumulation =
newCumulationBuffer(ctx, input.readableBytes());
cumulation.writeBytes(input);
replayable = new ReplayingDecoderBuffer(cumulation);
}
replayable = new ReplayingDecoderBuffer(cumulation);
} else {
this.cumulation = null;
replayable = ReplayingDecoderBuffer.EMPTY_BUFFER;