andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#575] Sending EMPTYBUFFER via NIO-UDP results in spaming the socket

Browse Source
This commit is contained in:
Trustin Lee 2012-08-30 14:04:13 +09:00
parent b4643c42aa
commit c4e7ecbb5d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannel.java
View File

@ -191,11 +191,12 @@ public final class NioDatagramChannel
protected int doWriteMessages(MessageBuf<Object> buf, boolean lastSpin) throws Exception {
DatagramPacket packet = (DatagramPacket) buf.peek();
ByteBuf data = packet.data();
int dataLen = data.readableBytes();
ByteBuffer nioData;
if (data.hasNioBuffer()) {
nioData = data.nioBuffer();
} else {
nioData = ByteBuffer.allocate(data.readableBytes());
nioData = ByteBuffer.allocate(dataLen);
data.getBytes(data.readerIndex(), nioData);
nioData.flip();
}
@ -204,7 +205,7 @@ public final class NioDatagramChannel
final SelectionKey key = selectionKey();
final int interestOps = key.interestOps();
if (writtenBytes <= 0) {
if (writtenBytes <= 0 && dataLen > 0) {
// Did not write a packet.
// 1) If 'lastSpin' is false, the caller will call this method again real soon.
// - Do not update OP_WRITE.