andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix inefficient loop in QueryStringDecoder.decodeComponent()

Browse Source 
- Fixes #2228
- There's no point of looping until the end of the component if at least one '%' or '+' is found.
This commit is contained in:
Trustin Lee 2014-02-14 13:25:57 -08:00
parent 6c02e19d10
commit c73e1e3c1e
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
View File

@ -311,13 +311,9 @@ public class QueryStringDecoder {
boolean modified = false; boolean modified = false;
for (int i = 0; i < size; i++) { for (int i = 0; i < size; i++) {
final char c = s.charAt(i); final char c = s.charAt(i);
switch (c) { if (c == '%' || c == '+') {
case '%': modified = true;
i++; // We can skip at least one char, e.g. `%%'. break;
// Fall through.
case '+':
modified = true;
break;
} }
} }
if (!modified) { if (!modified) {