From c78544cfaa5403f0599bcc8c73f3374295b4dd67 Mon Sep 17 00:00:00 2001 From: Michael Nitschinger Date: Fri, 22 Nov 2013 14:57:03 +0100 Subject: [PATCH] Avoid memory leak when encoding the key --- .../codec/memcache/binary/BinaryMemcacheEncoder.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheEncoder.java b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheEncoder.java index ce2660693a..11aaa7616f 100644 --- a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheEncoder.java +++ b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheEncoder.java @@ -64,7 +64,12 @@ public abstract class BinaryMemcacheEncoder, return; } - buf.writeBytes(Unpooled.copiedBuffer(key, CharsetUtil.UTF_8)); + ByteBuf keyBuf = Unpooled.copiedBuffer(key, CharsetUtil.UTF_8); + try { + buf.writeBytes(keyBuf); + } finally { + keyBuf.release(); + } } /**