From c7b164b4090b6675c9efd9f316e339a6a55d38c8 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Mon, 1 Jun 2015 13:55:20 +0900 Subject: [PATCH] Fix sporadic assertion failure in SocketSslEchoTest Motivation: SocketSslEchoTest.testSslEcho() has a race condition where a renegotiation future can be done before: assertThat(renegoFuture.isDone(), is(false)); Modifications: Remove the offending assertion. Result: More build stability --- .../io/netty/testsuite/transport/socket/SocketSslEchoTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketSslEchoTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketSslEchoTest.java index 05b23ec081..4bd8f3c0fc 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketSslEchoTest.java +++ b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketSslEchoTest.java @@ -300,7 +300,6 @@ public class SocketSslEchoTest extends AbstractSocketTest { renegoFuture = clientSslHandler.renegotiate(); logStats("CLIENT RENEGOTIATES"); assertThat(renegoFuture, is(not(sameInstance(clientHandshakeFuture)))); - assertThat(renegoFuture.isDone(), is(false)); } }