andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The constants calculation in compile-time

Browse Source 
Motivation:
Allow pre-computing calculation of the constants for compiler where it could be.
Similar fix in OpenJDK: [1].

Modifications:
- Use parentheses.
- Simplify static initialization of `BYTE2HEX_*` arrays in `StringUtil`.

Result:
Less bytecode, possible faster calculations at runtime.

[1] https://bugs.openjdk.java.net/browse/JDK-4477961
This commit is contained in:
Nikolay Fedorovskikh 2017-11-28 01:39:13 +05:00 committed by Norman Maurer
parent e329ca1cf3
commit c9668ce40f
2 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec/src/main/java/io/netty/handler/codec/compression/FastLz.java
View File

@ -168,7 +168,7 @@ final class FastLz {
readU16(input, inOffset + ip - 1) == readU16(input, inOffset + ip + 1)) { readU16(input, inOffset + ip - 1) == readU16(input, inOffset + ip + 1)) {
distance = 1; distance = 1;
ip += 3; ip += 3;
ref = anchor - 1 + 3; ref = anchor + (3 - 1);
/* /*
* goto match; * goto match;

18
common/src/main/java/io/netty/util/internal/StringUtil.java
View File

@ -48,19 +48,9 @@ public final class StringUtil {
static { static {
// Generate the lookup table that converts a byte into a 2-digit hexadecimal integer. // Generate the lookup table that converts a byte into a 2-digit hexadecimal integer.
int i; for (int i = 0; i < BYTE2HEX_PAD.length; i++) {
for (i = 0; i < 10; i++) {
BYTE2HEX_PAD[i] = "0" + i;
BYTE2HEX_NOPAD[i] = String.valueOf(i);
}
for (; i < 16; i++) {
char c = (char) ('a' + i - 10);
BYTE2HEX_PAD[i] = "0" + c;
BYTE2HEX_NOPAD[i] = String.valueOf(c);
}
for (; i < BYTE2HEX_PAD.length; i++) {
String str = Integer.toHexString(i); String str = Integer.toHexString(i);
BYTE2HEX_PAD[i] = str; BYTE2HEX_PAD[i] = i > 0xf ? str : ('0' + str);
BYTE2HEX_NOPAD[i] = str; BYTE2HEX_NOPAD[i] = str;
} }
} }
@ -226,10 +216,10 @@ public final class StringUtil {
return c - '0'; return c - '0';
} }
if (c >= 'A' && c <= 'F') { if (c >= 'A' && c <= 'F') {
return c - 'A' + 0xA; return c - ('A' - 0xA);
} }
if (c >= 'a' && c <= 'f') { if (c >= 'a' && c <= 'f') {
return c - 'a' + 0xA; return c - ('a' - 0xA);
} }
return -1; return -1;
} }