andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Only try to match SSLException message when debug logging is enabled.

Browse Source 
Motivation:

We only want to log for the particular case when debug logging is enabled so we not need to try to match the message if this is not the case.

Modifications:

Guard with logger.isDebugEnabled()

Result:

Less overhead when debug logging is not enabled.
This commit is contained in:
Norman Maurer 2017-12-05 15:27:57 +01:00
parent 2eddc921ce
commit ca1e1fcddf
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
handler/src/main/java/io/netty/handler/ssl/SslHandler.java
View File

@ -1506,6 +1506,7 @@ public class SslHandler extends ByteToMessageDecoder implements ChannelOutboundH
try { try {
engine.closeInbound(); engine.closeInbound();
} catch (SSLException e) { } catch (SSLException e) {
if (logger.isDebugEnabled()) {
// only log in debug mode as it most likely harmless and latest chrome still trigger // only log in debug mode as it most likely harmless and latest chrome still trigger
// this all the time. // this all the time.
// //
@ -1516,6 +1517,7 @@ public class SslHandler extends ByteToMessageDecoder implements ChannelOutboundH
} }
} }
} }
}
notifyHandshakeFailure(cause, notify); notifyHandshakeFailure(cause, notify);
} finally { } finally {
// Ensure we remove and fail all pending writes in all cases and so release memory quickly. // Ensure we remove and fail all pending writes in all cases and so release memory quickly.