From ca2e8c3b69d21954349303f5d7b117e325c90f0c Mon Sep 17 00:00:00 2001 From: Dmitriy Dumanskiy Date: Sat, 3 Aug 2019 13:20:41 +0300 Subject: [PATCH] Motivation: Look like `EmbeddedChannelPipeline` should also override `onUnhandledInboundMessage(ChannelHandlerContext ctx, Object msg)` in order to do not print "Discarded message pipeline" because in case of `EmbeddedChannelPipeline` discarding actually not happens. This fixes next warning in the latest netty version with websocket and `WebSocketServerCompressionHandler`: ``` 13:36:36.231 DEBUG- Decoding WebSocket Frame opCode=2 13:36:36.231 DEBUG- Decoding WebSocket Frame length=5 13:36:36.231 DEBUG- Discarded message pipeline : [JdkZlibDecoder#0, DefaultChannelPipeline$TailContext#0]. Channel : [id: 0xembedded, L:embedded - R:embedded]. ``` Modification: Override correct method Result: Follow up fix after https://github.com/netty/netty/pull/9286 --- .../main/java/io/netty/channel/embedded/EmbeddedChannel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java b/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java index b16b07d637..b026255244 100644 --- a/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java +++ b/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java @@ -872,7 +872,7 @@ public class EmbeddedChannel extends AbstractChannel { @Override protected void onUnhandledInboundMessage(ChannelHandlerContext ctx, Object msg) { - handleInboundMessage(msg); + handleInboundMessage(msg); } } }