andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Optimize ByteBufUtil.writeUsAscii(...) when AsciiString is used.

Browse Source 
Motivation:

When AsciiString is used we can optimize the write operation done by ByteBufUtil.writeUsAscii(...)

Modifications:

Sepcial handle AsciiString.

Result:

Faster writing of AsciiString.
This commit is contained in:
Norman Maurer 2015-09-02 11:52:01 +02:00
parent 30b30f77c6
commit cac51ab8d6
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
View File

@ -17,6 +17,7 @@ package io.netty.buffer;
import static io.netty.util.internal.ObjectUtil.checkNotNull; import static io.netty.util.internal.ObjectUtil.checkNotNull;
import io.netty.util.AsciiString;
import io.netty.util.ByteProcessor; import io.netty.util.ByteProcessor;
import io.netty.util.ByteString; import io.netty.util.ByteString;
import io.netty.util.CharsetUtil; import io.netty.util.CharsetUtil;
@ -498,7 +499,10 @@ public final class ByteBufUtil {
// ASCII uses 1 byte per char // ASCII uses 1 byte per char
final int len = seq.length(); final int len = seq.length();
buf.ensureWritable(len); buf.ensureWritable(len);
if (buf instanceof AbstractByteBuf) { if (seq instanceof AsciiString) {
AsciiString asciiString = (AsciiString) seq;
buf.writeBytes(asciiString.array(), asciiString.arrayOffset(), asciiString.length());
} else if (buf instanceof AbstractByteBuf) {
// Fast-Path // Fast-Path
AbstractByteBuf buffer = (AbstractByteBuf) buf; AbstractByteBuf buffer = (AbstractByteBuf) buf;
int writerIndex = buffer.writerIndex; int writerIndex = buffer.writerIndex;

13
buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
View File

@ -17,6 +17,8 @@ package io.netty.buffer;
import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import io.netty.util.AsciiString;
import io.netty.util.CharsetUtil; import io.netty.util.CharsetUtil;
import io.netty.util.ReferenceCountUtil; import io.netty.util.ReferenceCountUtil;
@ -105,4 +107,15 @@ public class ByteBufUtilTest {
Assert.assertEquals(buf, buf2); Assert.assertEquals(buf, buf2);
} }
@Test
public void testWriteUsAsciiString() {
AsciiString usAscii = new AsciiString("NettyRocks");
ByteBuf buf = ReferenceCountUtil.releaseLater(Unpooled.buffer(16));
buf.writeBytes(usAscii.toString().getBytes(CharsetUtil.US_ASCII));
ByteBuf buf2 = ReferenceCountUtil.releaseLater(Unpooled.buffer(16));
ByteBufUtil.writeAscii(buf2, usAscii);
Assert.assertEquals(buf, buf2);
}
} }