andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

HTTP/2 unit test failure race condition

Browse Source 
Motivation:
HttpToHttp2ConnectionHandler is awaiting on a future and a latch that may be competed before the buffers actually get released.  This test is attempting to validate that the buffer's refCnt() is 0 but there is no mechanism to wait on for a buffer's release() method to be called.

Modifications:
Remove the buffer refCnt() check.  The leak profile is designed to pick these up.

Result:
Unit tests that no longer have a race condition.
This commit is contained in:
Scott Mitchell 2014-12-12 13:50:33 -05:00
parent 83427022bf
commit cc8140b41c
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-http2/src/test/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandlerTest.java
View File

@ -132,7 +132,6 @@ public class HttpToHttp2ConnectionHandlerTest {
eq(http2Headers), eq(0), anyShort(), anyBoolean(), eq(0), eq(true)); eq(http2Headers), eq(0), anyShort(), anyBoolean(), eq(0), eq(true));
verify(serverListener, never()).onDataRead(any(ChannelHandlerContext.class), anyInt(), verify(serverListener, never()).onDataRead(any(ChannelHandlerContext.class), anyInt(),
any(ByteBuf.class), anyInt(), anyBoolean()); any(ByteBuf.class), anyInt(), anyBoolean());
assertEquals(0, request.refCnt());
} }
@Test @Test
@ -174,7 +173,6 @@ public class HttpToHttp2ConnectionHandlerTest {
eq(true)); eq(true));
assertEquals(1, receivedBuffers.size()); assertEquals(1, receivedBuffers.size());
assertEquals(text, receivedBuffers.get(0)); assertEquals(text, receivedBuffers.get(0));
assertEquals(0, request.refCnt());
} }
private void bootstrapEnv(int requestCountDown, int serverSettingsAckCount) throws Exception { private void bootstrapEnv(int requestCountDown, int serverSettingsAckCount) throws Exception {