From ccd231b8f42a717964ec52876037333dfa90e200 Mon Sep 17 00:00:00 2001 From: Trustin Lee Date: Sat, 7 Dec 2013 15:00:32 +0900 Subject: [PATCH] Fix a buffer leak in BinaryMemcacheDecoder --- .../handler/codec/memcache/binary/BinaryMemcacheDecoder.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheDecoder.java b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheDecoder.java index bc89779849..f9b798fb17 100644 --- a/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheDecoder.java +++ b/codec-memcache/src/main/java/io/netty/handler/codec/memcache/binary/BinaryMemcacheDecoder.java @@ -96,7 +96,8 @@ public abstract class BinaryMemcacheDecoder, return; } - currentKey = readBytes(ctx.alloc(), in, keyLength).toString(CharsetUtil.UTF_8); + currentKey = in.toString(in.readerIndex(), keyLength, CharsetUtil.UTF_8); + in.skipBytes(keyLength); } out.add(buildMessage(currentHeader, currentExtras, currentKey));