andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2653] Remove uncessary range checks for performance reasons

Browse Source 
Motivation:

I introduced range checks as part of 6c47cc97111146396d2daf1a97051135d2eaf69e in some places. Unfortunally I also added some where these are not needed and so caused a performance regression.

Modification:

Remove range checks where not needed

Result:

Fixed performance regression.
This commit is contained in:
Norman Maurer 2014-07-14 11:40:27 +02:00
parent 17b9e01780
commit ccd88596f3
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
View File

@ -998,17 +998,17 @@ public abstract class AbstractByteBuf extends ByteBuf {
public int forEachByte(ByteBufProcessor processor) { public int forEachByte(ByteBufProcessor processor) {
int index = readerIndex; int index = readerIndex;
int length = writerIndex - index; int length = writerIndex - index;
ensureAccessible();
return forEachByteAsc0(index, length, processor); return forEachByteAsc0(index, length, processor);
} }
@Override @Override
public int forEachByte(int index, int length, ByteBufProcessor processor) { public int forEachByte(int index, int length, ByteBufProcessor processor) {
checkIndex(index, length);
return forEachByteAsc0(index, length, processor); return forEachByteAsc0(index, length, processor);
} }
private int forEachByteAsc0(int index, int length, ByteBufProcessor processor) { private int forEachByteAsc0(int index, int length, ByteBufProcessor processor) {
checkIndex(index, length);
if (processor == null) { if (processor == null) {
throw new NullPointerException("processor"); throw new NullPointerException("processor");
} }
@ -1038,16 +1038,18 @@ public abstract class AbstractByteBuf extends ByteBuf {
public int forEachByteDesc(ByteBufProcessor processor) { public int forEachByteDesc(ByteBufProcessor processor) {
int index = readerIndex; int index = readerIndex;
int length = writerIndex - index; int length = writerIndex - index;
ensureAccessible();
return forEachByteDesc0(index, length, processor); return forEachByteDesc0(index, length, processor);
} }
@Override @Override
public int forEachByteDesc(int index, int length, ByteBufProcessor processor) { public int forEachByteDesc(int index, int length, ByteBufProcessor processor) {
checkIndex(index, length);
return forEachByteDesc0(index, length, processor); return forEachByteDesc0(index, length, processor);
} }
private int forEachByteDesc0(int index, int length, ByteBufProcessor processor) { private int forEachByteDesc0(int index, int length, ByteBufProcessor processor) {
checkIndex(index, length);
if (processor == null) { if (processor == null) {
throw new NullPointerException("processor"); throw new NullPointerException("processor");