andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make sure we always cleanup once ReplayingDecoder handles a message. See #259

Browse Source
This commit is contained in:
Norman Maurer 2012-04-20 20:17:30 +02:00
parent ec409751e1
commit ccf01d133a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
codec/src/main/java/io/netty/handler/codec/replay/ReplayingDecoder.java
View File

@ -293,6 +293,8 @@ public abstract class ReplayingDecoder<T extends Enum<T>>
private ReplayingDecoderBuffer replayable; private ReplayingDecoderBuffer replayable;
private T state; private T state;
private int checkpoint; private int checkpoint;
private boolean needsCleanup;
/** /**
* Creates a new instance with no initial state (i.e: {@code null}). * Creates a new instance with no initial state (i.e: {@code null}).
@ -429,6 +431,8 @@ public abstract class ReplayingDecoder<T extends Enum<T>>
return; return;
} }
needsCleanup = true;
if (cumulation == null) { if (cumulation == null) {
// the cumulation buffer is not created yet so just pass the input // the cumulation buffer is not created yet so just pass the input
// to callDecode(...) method // to callDecode(...) method
@ -570,8 +574,10 @@ public abstract class ReplayingDecoder<T extends Enum<T>>
throws Exception { throws Exception {
try { try {
ChannelBuffer cumulation = this.cumulation; ChannelBuffer cumulation = this.cumulation;
if (cumulation == null) { if (!needsCleanup) {
return; return;
} else {
needsCleanup = false;
} }
this.cumulation = null; this.cumulation = null;