andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* Added FIXME

Browse Source 
* Fixed potential selection key leak
This commit is contained in:
Trustin Lee 2008-12-08 15:17:59 +00:00
parent 7cbd2a272e
commit cd24a10d20
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/org/jboss/netty/channel/socket/nio/NioClientSocketPipelineSink.java
View File

@ -176,6 +176,8 @@ class NioClientSocketPipelineSink extends AbstractChannelSink {
} }
void register(NioSocketChannel channel) { void register(NioSocketChannel channel) {
// FIXME: Infinite loop on selector creation failure.
// Apply the same fix with what's applied in NioWorker.register()
boolean firstChannel = started.compareAndSet(false, true); boolean firstChannel = started.compareAndSet(false, true);
Selector selector; Selector selector;
if (firstChannel) { if (firstChannel) {
@ -312,6 +314,7 @@ class NioClientSocketPipelineSink extends AbstractChannelSink {
} }
private void close(SelectionKey k) { private void close(SelectionKey k) {
k.cancel();
NioSocketChannel ch = (NioSocketChannel) k.attachment(); NioSocketChannel ch = (NioSocketChannel) k.attachment();
NioWorker.close(ch, ch.getSucceededFuture()); NioWorker.close(ch, ch.getSucceededFuture());
} }