andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1517] Only fire the exception throught the pipeline if the channel is registered when using VoidChannelPromise

Browse Source
This commit is contained in:
Norman Maurer 2013-07-04 09:20:24 +02:00
parent f64a121de7
commit cea873286e
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
transport/src/main/java/io/netty/channel/VoidChannelPromise.java
View File

@ -150,9 +150,7 @@ final class VoidChannelPromise extends AbstractFuture<Void> implements ChannelPr
}
@Override
public VoidChannelPromise setFailure(Throwable cause) {
if (fireException) {
channel.pipeline().fireExceptionCaught(cause);
}
fireException(cause);
return this;
}
@ -163,17 +161,13 @@ final class VoidChannelPromise extends AbstractFuture<Void> implements ChannelPr
@Override
public boolean tryFailure(Throwable cause) {
if (fireException) {
channel.pipeline().fireExceptionCaught(cause);
}
fireException(cause);
return false;
}
@Override
public boolean cancel(boolean mayInterruptIfRunning) {
if (fireException) {
channel.pipeline().fireExceptionCaught(new CancellationException());
}
fireException(new CancellationException());
return false;
}
@ -200,4 +194,14 @@ final class VoidChannelPromise extends AbstractFuture<Void> implements ChannelPr
public Void getNow() {
return null;
}
private void fireException(Throwable cause) {
// Only fire the exception if the channel is open and registered
// if not the pipeline is not setup and so it would hit the tail
// of the pipeline.
// See https://github.com/netty/netty/issues/1517
if (fireException && channel.isRegistered()) {
channel.pipeline().fireExceptionCaught(cause);
}
}
}