From cee60304dea4eeb779aa60af08332b1a965de984 Mon Sep 17 00:00:00 2001
From: Scott Mitchell <scott.k.mitch1@gmail.com>
Date: Wed, 21 Jan 2015 15:10:07 -0500
Subject: [PATCH] Headers remove infrequently used member variables

Motivation:
There are two member variables (addAllVisitor, setAllVisitor) which are likely not to be used in the majority of use cases.

Modifications:
Remove these member variables and rely on a method to return a new object when needed.

Result:
Two less member variables for each DefaultHeaders instance.
---
 .../netty/handler/codec/DefaultHeaders.java   | 42 +++++++------------
 1 file changed, 14 insertions(+), 28 deletions(-)

diff --git a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
index 7605f3f340..342149c218 100644
--- a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
+++ b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
@@ -90,8 +90,6 @@ public class DefaultHeaders<T> implements Headers<T> {
     private final ValueConverter<T> valueConverter;
     private final NameConverter<T> nameConverter;
     private final int bucketSize;
-    private EntryVisitor<T> setAllVisitor;
-    private EntryVisitor<T> addAllVisitor;
     int size;
 
     @SuppressWarnings("unchecked")
@@ -1307,36 +1305,24 @@ public class DefaultHeaders<T> implements Headers<T> {
         return removed;
     }
 
-    /**
-     * Lazy initialization of the visitor which will set all headers.
-     */
     private EntryVisitor<T> setAllVisitor() {
-        if (setAllVisitor == null) {
-            setAllVisitor = new EntryVisitor<T>() {
-                @Override
-                public boolean visit(Entry<T, T> entry) {
-                    set(entry.getKey(), entry.getValue());
-                    return true;
-                }
-            };
-        }
-        return setAllVisitor;
+        return new EntryVisitor<T>() {
+            @Override
+            public boolean visit(Entry<T, T> entry) {
+                set(entry.getKey(), entry.getValue());
+                return true;
+            }
+        };
     }
 
-    /**
-     * Lazy initialization of the visitor which will add all headers.
-     */
     private EntryVisitor<T> addAllVisitor() {
-        if (addAllVisitor == null) {
-            addAllVisitor = new EntryVisitor<T>() {
-                @Override
-                public boolean visit(Entry<T, T> entry) {
-                    add(entry.getKey(), entry.getValue());
-                    return true;
-                }
-            };
-        }
-        return addAllVisitor;
+        return new EntryVisitor<T>() {
+            @Override
+            public boolean visit(Entry<T, T> entry) {
+                add(entry.getKey(), entry.getValue());
+                return true;
+            }
+        };
     }
 
     private final class HeaderEntry implements Map.Entry<T, T> {