diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java index b031a27486..7e931f4c10 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java @@ -19,7 +19,6 @@ package io.netty.handler.codec.http2; import io.netty.handler.codec.http2.Http2HeadersEncoder.SensitivityDetector; import io.netty.util.internal.UnstableApi; -import static io.netty.handler.codec.http2.Http2CodecUtil.DEFAULT_HEADER_LIST_SIZE; import static io.netty.handler.codec.http2.Http2CodecUtil.DEFAULT_MAX_RESERVED_STREAMS; import static io.netty.util.internal.ObjectUtil.checkNotNull; import static io.netty.util.internal.ObjectUtil.checkPositiveOrZero; @@ -79,7 +78,7 @@ public abstract class AbstractHttp2ConnectionHandlerBuilder { return super.keyToString(key); } } + + public static Http2Settings defaultSettings() { + return new Http2Settings().maxHeaderListSize(DEFAULT_HEADER_LIST_SIZE); + } } diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2CodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2CodecTest.java index b314023674..4302d259e7 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2CodecTest.java +++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2CodecTest.java @@ -72,7 +72,7 @@ public class Http2CodecTest { @Override protected void initChannel(Channel ch) throws Exception { serverConnectedChannel = ch; - ch.pipeline().addLast(new Http2Codec(true, serverLastInboundHandler)); + ch.pipeline().addLast(new Http2CodecBuilder(true, serverLastInboundHandler).build()); serverChannelLatch.countDown(); } }); @@ -81,7 +81,7 @@ public class Http2CodecTest { Bootstrap cb = new Bootstrap() .channel(LocalChannel.class) .group(group) - .handler(new Http2Codec(false, new TestChannelInitializer())); + .handler(new Http2CodecBuilder(false, new TestChannelInitializer()).build()); clientChannel = cb.connect(serverAddress).sync().channel(); assertTrue(serverChannelLatch.await(5, SECONDS)); } diff --git a/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2OrHttpHandler.java b/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2OrHttpHandler.java index c641fa3d39..7a4d13ed02 100644 --- a/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2OrHttpHandler.java +++ b/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2OrHttpHandler.java @@ -18,7 +18,7 @@ import io.netty.channel.ChannelHandlerContext; import io.netty.example.http2.helloworld.server.HelloWorldHttp1Handler; import io.netty.handler.codec.http.HttpObjectAggregator; import io.netty.handler.codec.http.HttpServerCodec; -import io.netty.handler.codec.http2.Http2Codec; +import io.netty.handler.codec.http2.Http2CodecBuilder; import io.netty.handler.ssl.ApplicationProtocolNames; import io.netty.handler.ssl.ApplicationProtocolNegotiationHandler; @@ -37,7 +37,7 @@ public class Http2OrHttpHandler extends ApplicationProtocolNegotiationHandler { @Override protected void configurePipeline(ChannelHandlerContext ctx, String protocol) throws Exception { if (ApplicationProtocolNames.HTTP_2.equals(protocol)) { - ctx.pipeline().addLast(new Http2Codec(true, new HelloWorldHttp2Handler())); + ctx.pipeline().addLast(new Http2CodecBuilder(true, new HelloWorldHttp2Handler()).build()); return; } diff --git a/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2ServerInitializer.java b/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2ServerInitializer.java index df38b7d46c..73012e6c5f 100644 --- a/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2ServerInitializer.java +++ b/example/src/main/java/io/netty/example/http2/helloworld/multiplex/server/Http2ServerInitializer.java @@ -29,7 +29,7 @@ import io.netty.handler.codec.http.HttpServerCodec; import io.netty.handler.codec.http.HttpServerUpgradeHandler; import io.netty.handler.codec.http.HttpServerUpgradeHandler.UpgradeCodec; import io.netty.handler.codec.http.HttpServerUpgradeHandler.UpgradeCodecFactory; -import io.netty.handler.codec.http2.Http2Codec; +import io.netty.handler.codec.http2.Http2CodecBuilder; import io.netty.handler.codec.http2.Http2CodecUtil; import io.netty.handler.codec.http2.Http2ServerUpgradeCodec; import io.netty.handler.ssl.SslContext; @@ -46,7 +46,7 @@ public class Http2ServerInitializer extends ChannelInitializer { @Override public UpgradeCodec newUpgradeCodec(CharSequence protocol) { if (AsciiString.contentEquals(Http2CodecUtil.HTTP_UPGRADE_PROTOCOL_NAME, protocol)) { - return new Http2ServerUpgradeCodec(new Http2Codec(true, new HelloWorldHttp2Handler())); + return new Http2ServerUpgradeCodec(new Http2CodecBuilder(true, new HelloWorldHttp2Handler()).build()); } else { return null; }