From cfe631ad0556b83f564babcb1616f4efc902ec59 Mon Sep 17 00:00:00 2001 From: skyguard1 Date: Fri, 28 May 2021 14:47:53 +0800 Subject: [PATCH] Add default block in DefaultHttpHeaders (#11329) Motivation: Every switch block should also have a default case. Modification: Add default block in DefaultHttpHeaders to ensure we not fall-through by mistake Result: Cleanup Signed-off-by: xingrufei --- .../io/netty/handler/codec/http/DefaultHttpHeaders.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java index b667de40f7..ddd68c74d9 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java +++ b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java @@ -475,6 +475,8 @@ public class DefaultHttpHeaders extends HttpHeaders { throw new IllegalArgumentException("a header value contains a prohibited character '\\v': " + seq); case '\f': throw new IllegalArgumentException("a header value contains a prohibited character '\\f': " + seq); + default: + break; } } @@ -486,6 +488,8 @@ public class DefaultHttpHeaders extends HttpHeaders { return 1; case '\n': return 2; + default: + break; } break; case 1: @@ -501,6 +505,8 @@ public class DefaultHttpHeaders extends HttpHeaders { default: throw new IllegalArgumentException("only ' ' and '\\t' are allowed after '\\n': " + seq); } + default: + break; } return state; }