andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add test for caching failed queries in DefaultDnsCache. (#7909)

Browse Source 
Motivation:

We had no test that validated the handling of caching failures for DefaultDnsCache.

Modifications:

Add testcase.

Result:

More tests FTW.
This commit is contained in:
Norman Maurer 2018-05-04 20:09:38 +02:00 committed by GitHub
parent 358249e5c9
commit d03bd44e9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
resolver-dns/src/test/java/io/netty/resolver/dns/DefaultDnsCacheTest.java
View File

@ -32,6 +32,7 @@ import java.util.concurrent.TimeUnit;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
public class DefaultDnsCacheTest {
@ -129,4 +130,33 @@ public class DefaultDnsCacheTest {
assertEquals(address, entry.address());
assertNull(entry.cause());
}
@Test
public void testCacheFailed() throws Exception {
InetAddress addr1 = InetAddress.getByAddress(new byte[] { 10, 0, 0, 1 });
InetAddress addr2 = InetAddress.getByAddress(new byte[] { 10, 0, 0, 2 });
EventLoopGroup group = new DefaultEventLoopGroup(1);
try {
EventLoop loop = group.next();
final DefaultDnsCache cache = new DefaultDnsCache(1, 100, 100);
cache.cache("netty.io", null, addr1, 10000, loop);
cache.cache("netty.io", null, addr2, 10000, loop);
List<? extends DnsCacheEntry> entries = cache.get("netty.io", null);
assertEquals(2, entries.size());
assertEntry(entries.get(0), addr1);
assertEntry(entries.get(1), addr2);
Exception exception = new Exception();
cache.cache("netty.io", null, exception, loop);
entries = cache.get("netty.io", null);
DnsCacheEntry entry = entries.get(0);
assertEquals(1, entries.size());
assertSame(exception, entry.cause());
assertNull(entry.address());
} finally {
group.shutdownGracefully();
}
}
}