From d040c939e54cee8b390dd5ab0219c2bd8944610f Mon Sep 17 00:00:00 2001 From: Scott Mitchell Date: Wed, 5 Jul 2017 13:03:29 -0400 Subject: [PATCH] UnixResolverDnsServerAddressStreamProviderTest failure Motivation: InetSocketAddress#getHostName() may attempt a reverse lookup which may lead to test failures because the expected address will not match. Modifications: - Use InetSocketAddress#getHostString() which will not attempt any lookups and instead return the original String Result: UnixResolverDnsServerAddressStreamProviderTest is more reliable. --- .../dns/UnixResolverDnsServerAddressStreamProviderTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java index cf8b1d6521..bbb31f1f28 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java +++ b/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java @@ -111,6 +111,6 @@ public class UnixResolverDnsServerAddressStreamProviderTest { } private static void assertHostNameEquals(String expectedHostname, InetSocketAddress next) { - assertEquals("unexpected hostname: " + next, expectedHostname, next.getHostName()); + assertEquals("unexpected hostname: " + next, expectedHostname, next.getHostString()); } }