From d13ac5290a82383059c7e3619e86f3a5f689cc8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=97=B6=E6=97=A0=E4=B8=A4=E4=B8=B6?= <442367943@qq.com> Date: Wed, 6 Nov 2019 16:43:25 +0800 Subject: [PATCH] Clean up expired docs. (#9756) Motivation: Since the `extractFrame` has used `retainedSlice` to avoid memory copy, we should clean this doc that was expired. Result: Better doc. --- .../netty/handler/codec/LengthFieldBasedFrameDecoder.java | 8 -------- 1 file changed, 8 deletions(-) diff --git a/codec/src/main/java/io/netty/handler/codec/LengthFieldBasedFrameDecoder.java b/codec/src/main/java/io/netty/handler/codec/LengthFieldBasedFrameDecoder.java index 497f92c683..63aabc6b76 100644 --- a/codec/src/main/java/io/netty/handler/codec/LengthFieldBasedFrameDecoder.java +++ b/codec/src/main/java/io/netty/handler/codec/LengthFieldBasedFrameDecoder.java @@ -494,14 +494,6 @@ public class LengthFieldBasedFrameDecoder extends ByteToMessageDecoder { /** * Extract the sub-region of the specified buffer. - *

- * If you are sure that the frame and its content are not accessed after - * the current {@link #decode(ChannelHandlerContext, ByteBuf)} - * call returns, you can even avoid memory copy by returning the sliced - * sub-region (i.e. return buffer.slice(index, length)). - * It's often useful when you convert the extracted frame into an object. - * Refer to the source code of {@link ObjectDecoder} to see how this method - * is overridden to avoid memory copy. */ protected ByteBuf extractFrame(ChannelHandlerContext ctx, ByteBuf buffer, int index, int length) { return buffer.retainedSlice(index, length);