andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#2925] Bug fix for NormalMemoryRegionCache overbooked for PoolThreadCache

Browse Source 
Motivation:

When create NormalMemoryRegionCache for PoolThreadCache, we overbooked
cache array size. This means unnecessary overhead for thread local cache
as we will create multi cache enties for each element in cache array.

Modifications:

change:
int arraySize = Math.max(1, max / area.pageSize);
to:
int arraySize = Math.max(1, log2(max / area.pageSize) + 1);

Result:

Now arraySize won't introduce unnecessary overhead.

 Changes to be committed:
	modified:   buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
This commit is contained in:
garywu 2015-04-13 13:41:25 +08:00 committed by Norman Maurer
parent 418c81542b
commit d14afe88a4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
View File

@ -129,7 +129,7 @@ final class PoolThreadCache {
int cacheSize, int maxCachedBufferCapacity, PoolArena<T> area) { int cacheSize, int maxCachedBufferCapacity, PoolArena<T> area) {
if (cacheSize > 0) { if (cacheSize > 0) {
int max = Math.min(area.chunkSize, maxCachedBufferCapacity); int max = Math.min(area.chunkSize, maxCachedBufferCapacity);
int arraySize = Math.max(1, max / area.pageSize); int arraySize = Math.max(1, log2(max / area.pageSize) + 1);
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
NormalMemoryRegionCache<T>[] cache = new NormalMemoryRegionCache[arraySize]; NormalMemoryRegionCache<T>[] cache = new NormalMemoryRegionCache[arraySize];