From d15f9eda080b424706528d6f9d0158eef8ad2607 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Thu, 15 Nov 2012 13:00:44 +0100 Subject: [PATCH] [#740] Fix WebSocketClientHandshaker00.finishHandshake() validations --- .../http/websocketx/WebSocketClientHandshaker00.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java b/src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java index e39824f884..9018a49714 100644 --- a/src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java +++ b/src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java @@ -243,19 +243,19 @@ public class WebSocketClientHandshaker00 extends WebSocketClientHandshaker { } String upgrade = response.getHeader(Names.UPGRADE); - if (Values.WEBSOCKET.equals(upgrade)) { + if (!Values.WEBSOCKET.equals(upgrade)) { throw new WebSocketHandshakeException("Invalid handshake response upgrade: " - + response.getHeader(Names.UPGRADE)); + + upgrade); } String connection = response.getHeader(Names.CONNECTION); - if (Values.UPGRADE.equals(connection)) { + if (!Values.UPGRADE.equals(connection)) { throw new WebSocketHandshakeException("Invalid handshake response connection: " - + response.getHeader(Names.CONNECTION)); + + connection); } ChannelBuffer challenge = response.getContent(); - if (challenge.equals(expectedChallengeResponseBytes)) { + if (!challenge.equals(expectedChallengeResponseBytes)) { throw new WebSocketHandshakeException("Invalid challenge"); }