andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#740] Fix WebSocketClientHandshaker00.finishHandshake() validations

Browse Source
This commit is contained in:
Norman Maurer 2012-11-15 13:00:44 +01:00
parent 1e8ed50482
commit d15f9eda08
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/org/jboss/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java
View File

@ -243,19 +243,19 @@ public class WebSocketClientHandshaker00 extends WebSocketClientHandshaker {
} }
String upgrade = response.getHeader(Names.UPGRADE); String upgrade = response.getHeader(Names.UPGRADE);
if (Values.WEBSOCKET.equals(upgrade)) { if (!Values.WEBSOCKET.equals(upgrade)) {
throw new WebSocketHandshakeException("Invalid handshake response upgrade: " throw new WebSocketHandshakeException("Invalid handshake response upgrade: "
+ response.getHeader(Names.UPGRADE)); + upgrade);
} }
String connection = response.getHeader(Names.CONNECTION); String connection = response.getHeader(Names.CONNECTION);
if (Values.UPGRADE.equals(connection)) { if (!Values.UPGRADE.equals(connection)) {
throw new WebSocketHandshakeException("Invalid handshake response connection: " throw new WebSocketHandshakeException("Invalid handshake response connection: "
+ response.getHeader(Names.CONNECTION)); + connection);
} }
ChannelBuffer challenge = response.getContent(); ChannelBuffer challenge = response.getContent();
if (challenge.equals(expectedChallengeResponseBytes)) { if (!challenge.equals(expectedChallengeResponseBytes)) {
throw new WebSocketHandshakeException("Invalid challenge"); throw new WebSocketHandshakeException("Invalid challenge");
} }