andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#5551] Fix sporadic GlobalEventExecutorTest.testAutomaticStartStop test failure

Browse Source 
Motivation:

We saw some sporadic test failures for GlobalEventExecutorTest.testAutomaticStartStop test. This is caused parallel execution of tests in combination with assert checks that will be affected.

Modifications:

Remove fragile assert checks.

Result:

No more sporadic test failures
This commit is contained in:
Norman Maurer 2016-07-22 21:33:23 +02:00
parent fe4af7e32c
commit d315f1b3ba
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common/src/test/java/io/netty/util/concurrent/GlobalEventExecutorTest.java
View File

@ -61,7 +61,6 @@ public class GlobalEventExecutorTest {
// Ensure the thread stopped itself after running the task. // Ensure the thread stopped itself after running the task.
assertThat(thread.isAlive(), is(false)); assertThat(thread.isAlive(), is(false));
assertThat(task.ran.get(), is(true)); assertThat(task.ran.get(), is(true));
assertThat(e.thread, sameInstance(thread));
// Ensure another new thread starts again. // Ensure another new thread starts again.
task.ran.set(false); task.ran.set(false);
@ -74,7 +73,6 @@ public class GlobalEventExecutorTest {
// Ensure the thread stopped itself after running the task. // Ensure the thread stopped itself after running the task.
assertThat(thread.isAlive(), is(false)); assertThat(thread.isAlive(), is(false));
assertThat(task.ran.get(), is(true)); assertThat(task.ran.get(), is(true));
assertThat(e.thread, sameInstance(thread));
} }
@Test @Test
@ -93,7 +91,6 @@ public class GlobalEventExecutorTest {
// Now it should be stopped. // Now it should be stopped.
assertThat(thread.isAlive(), is(false)); assertThat(thread.isAlive(), is(false));
assertThat(e.thread, sameInstance(thread));
} }
// ensure that when a task submission causes a new thread to be created, the thread inherits the thread group of the // ensure that when a task submission causes a new thread to be created, the thread inherits the thread group of the