Add 'static' modifier to the methods that don't need to be member methods
This commit is contained in:
parent
ffe5459a88
commit
d638052036
@ -31,7 +31,7 @@ public final class CaseIgnoringComparator implements Comparator<String>, Seriali
|
||||
return o1.compareToIgnoreCase(o2);
|
||||
}
|
||||
|
||||
@SuppressWarnings("static-method")
|
||||
@SuppressWarnings("MethodMayBeStatic")
|
||||
private Object readResolve() {
|
||||
return INSTANCE;
|
||||
}
|
||||
|
@ -15,10 +15,6 @@
|
||||
*/
|
||||
package org.jboss.netty.handler.codec.http;
|
||||
|
||||
import static org.junit.Assert.*;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
import org.easymock.EasyMock;
|
||||
import org.jboss.netty.buffer.ChannelBuffer;
|
||||
import org.jboss.netty.buffer.ChannelBuffers;
|
||||
@ -30,6 +26,10 @@ import org.jboss.netty.handler.codec.frame.TooLongFrameException;
|
||||
import org.jboss.netty.util.CharsetUtil;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
import static org.junit.Assert.*;
|
||||
|
||||
public class HttpChunkAggregatorTest {
|
||||
|
||||
@Test
|
||||
@ -59,7 +59,7 @@ public class HttpChunkAggregatorTest {
|
||||
|
||||
}
|
||||
|
||||
private void checkContentBuffer(HttpMessage aggregatedMessage) {
|
||||
private static void checkContentBuffer(HttpMessage aggregatedMessage) {
|
||||
CompositeChannelBuffer buffer = (CompositeChannelBuffer) aggregatedMessage.getContent();
|
||||
assertEquals(2, buffer.numComponents());
|
||||
List<ChannelBuffer> buffers = buffer.decompose(0, buffer.capacity());
|
||||
|
@ -58,7 +58,7 @@ public class HttpServerCodecTest {
|
||||
Assert.assertEquals(offeredContentLength, totalBytesPolled);
|
||||
}
|
||||
|
||||
private ChannelBuffer prepareDataChunk(int size) {
|
||||
private static ChannelBuffer prepareDataChunk(int size) {
|
||||
StringBuilder sb = new StringBuilder();
|
||||
for (int i = 0; i < size; ++i) {
|
||||
sb.append("a");
|
||||
|
@ -15,17 +15,6 @@
|
||||
*/
|
||||
package org.jboss.netty.handler.codec.http.websocketx;
|
||||
|
||||
import static org.jboss.netty.handler.codec.http.HttpHeaders.Values.WEBSOCKET;
|
||||
import static org.jboss.netty.handler.codec.http.HttpResponseStatus.FORBIDDEN;
|
||||
import static org.jboss.netty.handler.codec.http.HttpResponseStatus.SWITCHING_PROTOCOLS;
|
||||
import static org.jboss.netty.handler.codec.http.HttpVersion.HTTP_1_1;
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertNotNull;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
||||
import java.util.LinkedList;
|
||||
import java.util.Queue;
|
||||
|
||||
import org.jboss.netty.channel.Channel;
|
||||
import org.jboss.netty.channel.ChannelHandlerContext;
|
||||
import org.jboss.netty.channel.MessageEvent;
|
||||
@ -40,6 +29,14 @@ import org.jboss.netty.handler.codec.http.HttpResponse;
|
||||
import org.jboss.netty.handler.codec.http.HttpResponseEncoder;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.util.LinkedList;
|
||||
import java.util.Queue;
|
||||
|
||||
import static org.jboss.netty.handler.codec.http.HttpHeaders.Values.*;
|
||||
import static org.jboss.netty.handler.codec.http.HttpResponseStatus.*;
|
||||
import static org.jboss.netty.handler.codec.http.HttpVersion.*;
|
||||
import static org.junit.Assert.*;
|
||||
|
||||
public class WebSocketServerProtocolHandlerTest {
|
||||
|
||||
@Test
|
||||
@ -55,7 +52,7 @@ public class WebSocketServerProtocolHandlerTest {
|
||||
assertNotNull(WebSocketServerProtocolHandler.getHandshaker(ctx));
|
||||
}
|
||||
|
||||
private HttpResponseInterceptor addHttpResponseInterceptor(DecoderEmbedder<Object> embedder) {
|
||||
private static HttpResponseInterceptor addHttpResponseInterceptor(DecoderEmbedder<Object> embedder) {
|
||||
HttpResponseInterceptor interceptor = new HttpResponseInterceptor();
|
||||
embedder.getPipeline().addLast("httpEncoder", interceptor);
|
||||
return interceptor;
|
||||
@ -110,7 +107,7 @@ public class WebSocketServerProtocolHandlerTest {
|
||||
}
|
||||
}
|
||||
|
||||
private void assertWebSocketHandshakeException(Exception e) {
|
||||
private static void assertWebSocketHandshakeException(Exception e) {
|
||||
assertTrue(e instanceof CodecEmbedderException);
|
||||
assertTrue(e.getCause() instanceof WebSocketHandshakeException);
|
||||
}
|
||||
@ -132,7 +129,7 @@ public class WebSocketServerProtocolHandlerTest {
|
||||
return decoder;
|
||||
}
|
||||
|
||||
private DecoderEmbedder<Object> decoderEmbedder() {
|
||||
private static DecoderEmbedder<Object> decoderEmbedder() {
|
||||
DecoderEmbedder<Object> decoder = new DecoderEmbedder<Object>(
|
||||
new HttpRequestDecoder(),
|
||||
new WebSocketServerProtocolHandler("path"));
|
||||
|
Loading…
Reference in New Issue
Block a user