From d688e35e70ea307759976fc32d177b2748d0a14e Mon Sep 17 00:00:00 2001 From: Roger Kapsi Date: Thu, 2 Feb 2017 16:14:12 -0500 Subject: [PATCH] Fixing argument names Motivation Misleading argument names Modifications Stripping xMillis suffix from arguments because there's a TimeUnit Result Less confusion --- .../src/main/java/io/netty/handler/ssl/SslHandler.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java index 8e920c285f..40a07d45f4 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java @@ -417,8 +417,8 @@ public class SslHandler extends ByteToMessageDecoder implements ChannelOutboundH * {@link Channel}. If the close_notify was not flushed in the given timeout the {@link Channel} will be closed * forcibily. */ - public final void setCloseNotifyFlushTimeout(long closeNotifyFlushTimeoutMillis, TimeUnit unit) { - setCloseNotifyFlushTimeoutMillis(unit.toMillis(closeNotifyFlushTimeoutMillis)); + public final void setCloseNotifyFlushTimeout(long closeNotifyFlushTimeout, TimeUnit unit) { + setCloseNotifyFlushTimeoutMillis(unit.toMillis(closeNotifyFlushTimeout)); } /** @@ -446,8 +446,8 @@ public class SslHandler extends ByteToMessageDecoder implements ChannelOutboundH * {@link Channel}. This timeout starts after the close_notify message was successfully written to the * remote peer. Use {@code 0} to directly close the {@link Channel} and not wait for the response. */ - public final void setCloseNotifyReadTimeout(long closeNotifyReadTimeoutMillis, TimeUnit unit) { - setCloseNotifyReadTimeoutMillis(unit.toMillis(closeNotifyReadTimeoutMillis)); + public final void setCloseNotifyReadTimeout(long closeNotifyReadTimeout, TimeUnit unit) { + setCloseNotifyReadTimeoutMillis(unit.toMillis(closeNotifyReadTimeout)); } /**