From d7ff71a3d1d0ba16818ebe8ab44691197c2ffd48 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 16 Jan 2017 13:06:13 +0100 Subject: [PATCH] Check if DnsCache is null in DnsNameResolver constructor. Motivation: We miss checking if DnsCache is null in DnsNameResolver constructor which will later then lead to a NPE. Better fail fast here. Modifications: Check for null and if so throw a NPE. Result: Fail fast. --- .../src/main/java/io/netty/resolver/dns/DnsNameResolver.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java index 0706fbe788..84495f9b74 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java +++ b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java @@ -196,7 +196,7 @@ public class DnsNameResolver extends InetNameResolver { this.maxPayloadSize = checkPositive(maxPayloadSize, "maxPayloadSize"); this.optResourceEnabled = optResourceEnabled; this.hostsFileEntriesResolver = checkNotNull(hostsFileEntriesResolver, "hostsFileEntriesResolver"); - this.resolveCache = resolveCache; + this.resolveCache = checkNotNull(resolveCache, "resolveCache"); this.searchDomains = checkNotNull(searchDomains, "searchDomains").clone(); this.ndots = checkPositiveOrZero(ndots, "ndots");