From d900f8c21d2c8205eff3fb392f1b6f134dc447a1 Mon Sep 17 00:00:00 2001
From: Norman Maurer <nmaurer@redhat.com>
Date: Fri, 5 Jul 2013 06:27:25 +0200
Subject: [PATCH] [#1524] Fix resource leak in HttpContentEncoder

---
 .../handler/codec/http/HttpContentEncoder.java  | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
index 9f77492c75..786fa6020d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
@@ -256,7 +256,18 @@ public abstract class HttpContentEncoder extends MessageToMessageCodec<HttpReque
     private void cleanup() {
         if (encoder != null) {
             // Clean-up the previous encoder if not cleaned up correctly.
-            finishEncode(Unpooled.buffer());
+            if (encoder.finish()) {
+                for (;;) {
+                    ByteBuf buf = (ByteBuf) encoder.readOutbound();
+                    if (buf == null) {
+                        break;
+                    }
+                    // Release the buffer
+                    // https://github.com/netty/netty/issues/1524
+                    buf.release();
+                }
+            }
+            encoder = null;
         }
     }
 
@@ -280,6 +291,10 @@ public abstract class HttpContentEncoder extends MessageToMessageCodec<HttpReque
                 break;
             }
             out.writeBytes(buf);
+
+            // Need to release the buffer after write it
+            // See https://github.com/netty/netty/issues/1524
+            buf.release();
         }
     }