andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Sorted cases in switch statements just in case compiler makes a mistake

Browse Source
This commit is contained in:
Trustin Lee 2010-01-09 05:38:34 +00:00
parent 9c0e9e1780
commit d924439330
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/org/jboss/netty/handler/codec/http/DefaultCookie.java
View File

@ -83,9 +83,8 @@ public class DefaultCookie implements Cookie {
// Check prohibited characters.
switch (c) {
case '=': case ',': case ';': case ' ':
case '\t': case '\r': case '\n': case '\f':
case 0x0b: // Vertical tab
case '\t': case '\n': case 0x0b: case '\f': case '\r':
case ' ': case ',': case ';': case '=':
throw new IllegalArgumentException(
"name contains one of the following prohibited characters: " +
"=,; \\t\\r\\n\\v\\f: " + name);

13
src/main/java/org/jboss/netty/handler/codec/http/HttpCodecUtil.java
View File

@ -88,9 +88,8 @@ class HttpCodecUtil {
// Check prohibited characters.
switch (c) {
case '=': case ',': case ';': case ' ': case ':':
case '\t': case '\r': case '\n': case '\f':
case 0x0b: // Vertical tab
case '\t': case '\n': case 0x0b: case '\f': case '\r':
case ' ': case ',': case ':': case ';': case '=':
throw new IllegalArgumentException(
"name contains one of the following prohibited characters: " +
"=,;: \\t\\r\\n\\v\\f: " + name);
@ -113,12 +112,12 @@ class HttpCodecUtil {
// Check the absolutely prohibited characters.
switch (c) {
case '\f':
throw new IllegalArgumentException(
"value contains a prohibited character '\\f': " + value);
case 0x0b: // Vertical tab
throw new IllegalArgumentException(
"value contains a prohibited character '\\v': " + value);
case '\f':
throw new IllegalArgumentException(
"value contains a prohibited character '\\f': " + value);
}
// Check the CRLF (HT | SP) pattern
@ -145,7 +144,7 @@ class HttpCodecUtil {
break;
case 2:
switch (c) {
case ' ': case '\t':
case '\t': case ' ':
state = 0;
break;
default: