andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1159] Make sure we not produce an empty bytebuf on decodeLast(..)

Browse Source
This commit is contained in:
Norman Maurer 2013-03-14 12:45:24 +01:00
parent 835a40fa25
commit d9c3f4bc05
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
codec-http/src/main/java/io/netty/handler/codec/http/HttpClientCodec.java
View File

@ -148,7 +148,13 @@ public final class HttpClientCodec
protected Object decode(
ChannelHandlerContext ctx, ByteBuf buffer) throws Exception {
if (done) {
return buffer.readBytes(actualReadableBytes());
int readable = actualReadableBytes();
if (readable == 0) {
// if non is readable just return null
// https://github.com/netty/netty/issues/1159
return null;
}
return buffer.readBytes(readable);
} else {
Object msg = super.decode(ctx, buffer);
if (failOnMissingResponse) {