andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix ByteBufChecksum optimisation for CRC32 and Adler32 (#9242)

Browse Source 
Motivation:

Because of a simple bug in ByteBufChecksum#updateByteBuffer(Checksum),
ReflectiveByteBufChecksum is never used for CRC32 and Adler32, resulting
in direct ByteBuffers being checksummed byte by byte, which is
undesriable.

Modification:

Fix ByteBufChecksum#updateByteBuffer(Checksum) method to pass the
correct argument to Method#invoke(Checksum, ByteBuffer).

Result:

ReflectiveByteBufChecksum will now be used for Adler32 and CRC32 on
Java8+ and direct ByteBuffers will no longer be checksummed on slow
byte-by-byte basis.
This commit is contained in:
Aleksey Yeschenko 2019-06-16 06:32:51 +01:00 committed by Norman Maurer
parent acd13e1cf7
commit db1e662933
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec/src/main/java/io/netty/handler/codec/compression/ByteBufChecksum.java
View File

@ -51,7 +51,7 @@ abstract class ByteBufChecksum implements Checksum {
private static Method updateByteBuffer(Checksum checksum) { private static Method updateByteBuffer(Checksum checksum) {
try { try {
Method method = checksum.getClass().getDeclaredMethod("update", ByteBuffer.class); Method method = checksum.getClass().getDeclaredMethod("update", ByteBuffer.class);
method.invoke(method, ByteBuffer.allocate(1)); method.invoke(checksum, ByteBuffer.allocate(1));
return method; return method;
} catch (Throwable ignore) { } catch (Throwable ignore) {
return null; return null;