andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use LinkedHashSet for HttpHeaders.names() and add Javadoc about the performance of names() and entries()

Browse Source
This commit is contained in:
Trustin Lee 2013-12-22 19:16:49 +09:00
parent fc2e6916d9
commit dd49b1cfac
2 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java
View File

@ -21,13 +21,13 @@ import java.util.Arrays;
import java.util.Calendar; import java.util.Calendar;
import java.util.Date; import java.util.Date;
import java.util.Iterator; import java.util.Iterator;
import java.util.LinkedHashSet;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Map.Entry; import java.util.Map.Entry;
import java.util.NoSuchElementException; import java.util.NoSuchElementException;
import java.util.Set; import java.util.Set;
import java.util.TreeSet;
public class DefaultHttpHeaders extends HttpHeaders { public class DefaultHttpHeaders extends HttpHeaders {
@ -372,9 +372,7 @@ public class DefaultHttpHeaders extends HttpHeaders {
@Override @Override
public Set<String> names() { public Set<String> names() {
Set<String> names = new LinkedHashSet<String>();
Set<String> names = new TreeSet<String>(String.CASE_INSENSITIVE_ORDER);
HeaderEntry e = head.after; HeaderEntry e = head.after;
while (e != head) { while (e != head) {
names.add(e.getKey()); names.add(e.getKey());

17
codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java
View File

@ -27,9 +27,7 @@ import java.util.Map;
import java.util.Map.Entry; import java.util.Map.Entry;
import java.util.Set; import java.util.Set;
import static io.netty.handler.codec.http.HttpConstants.*;
import static io.netty.handler.codec.http.HttpConstants.CR;
import static io.netty.handler.codec.http.HttpConstants.LF;
/** /**
* Provides the constants for the standard HTTP header names and values and * Provides the constants for the standard HTTP header names and values and
@ -1431,10 +1429,9 @@ public abstract class HttpHeaders implements Iterable<Map.Entry<String, String>>
} }
/** /**
* Returns the all headers that this message contains. * Returns a new {@link List} that contains all headers in this object. Note that modifying the
* * returned {@link List} will not affect the state of this object. If you intend to enumerate over the header
* @return A {@link List} of the header name-value entries, which will be * entries only, use {@link #iterator()} instead, which has much less overhead.
* empty if no pairs are found
*/ */
public abstract List<Map.Entry<String, String>> entries(); public abstract List<Map.Entry<String, String>> entries();
@ -1459,9 +1456,9 @@ public abstract class HttpHeaders implements Iterable<Map.Entry<String, String>>
public abstract boolean isEmpty(); public abstract boolean isEmpty();
/** /**
* Gets a {@link Set} of all header names that this message contains * Returns a new {@link Set} that contains the names of all headers in this object. Note that modifying the
* * returned {@link Set} will not affect the state of this object. If you intend to enumerate over the header
* @return A {@link Set} of all header names * entries only, use {@link #iterator()} instead, which has much less overhead.
*/ */
public abstract Set<String> names(); public abstract Set<String> names();