From df4e236de2de646f245d540e647f22a7c61c55d6 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Sat, 29 Jun 2019 09:23:38 +0200 Subject: [PATCH] Http2FrameCodecBuilder.autoAckSettingsFrame(...) must be public (#9295) Motivation: b3dba317d797e21cc253bb6ad6776307297f612e added AbstractHttp2ConnectionBuilder.autoAckSettingsFrame(...) as protected method and made it public for Http2MultiplexCodecBuilder. Unfortunally it did miss to also make it public in Http2FrameCodecBuilder Modifications: Correctly override autoAckSettingsFrame in Http2FrameCodecBuilder and so make it usable when building Http2FrameCodec. Result: Be able to also configure autoAckSettingsFrame when Http2FrameCodec is used. --- .../io/netty/handler/codec/http2/Http2FrameCodecBuilder.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodecBuilder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodecBuilder.java index b448fad171..c27e9b5209 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodecBuilder.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodecBuilder.java @@ -141,6 +141,11 @@ public class Http2FrameCodecBuilder extends return super.initialHuffmanDecodeCapacity(initialHuffmanDecodeCapacity); } + @Override + public Http2FrameCodecBuilder autoAckSettingsFrame(boolean autoAckSettings) { + return super.autoAckSettingsFrame(autoAckSettings); + } + @Override public Http2FrameCodecBuilder decoupleCloseAndGoAway(boolean decoupleCloseAndGoAway) { return super.decoupleCloseAndGoAway(decoupleCloseAndGoAway);