andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1475] Correctly handle writes with empty MessageList in SslHandler

Browse Source
This commit is contained in:
Norman Maurer 2013-06-20 16:07:36 +02:00 committed by Trustin Lee
parent ad73dce7a1
commit e06fcdbc6a
2 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
handler/src/main/java/io/netty/handler/ssl/SslHandler.java
View File

@ -392,6 +392,13 @@ public class SslHandler
ctx.write(msgs, promise); ctx.write(msgs, promise);
return; return;
} }
try {
if (msgs.isEmpty()) {
// if the MessageList is empty we need to add an empty buffer as pending write as otherwise
// the promise will never be notified.
// See https://github.com/netty/netty/issues/1475
pendingUnencryptedWrites.add(new PendingWrite(Unpooled.EMPTY_BUFFER, promise));
} else {
for (int i = 0; i < msgs.size(); i++) { for (int i = 0; i < msgs.size(); i++) {
ByteBuf msg = (ByteBuf) msgs.get(i); ByteBuf msg = (ByteBuf) msgs.get(i);
ChannelPromise cp; ChannelPromise cp;
@ -402,7 +409,11 @@ public class SslHandler
} }
pendingUnencryptedWrites.add(new PendingWrite(msg, cp)); pendingUnencryptedWrites.add(new PendingWrite(msg, cp));
} }
}
flush0(ctx); flush0(ctx);
} finally {
msgs.recycle();
}
} }
private void flush0(ChannelHandlerContext ctx) throws SSLException { private void flush0(ChannelHandlerContext ctx) throws SSLException {

3
testsuite/src/test/java/io/netty/testsuite/transport/socket/SocketSslEchoTest.java
View File

@ -111,10 +111,7 @@ public class SocketSslEchoTest extends AbstractSocketTest {
for (int i = FIRST_MESSAGE_SIZE; i < data.length;) { for (int i = FIRST_MESSAGE_SIZE; i < data.length;) {
int length = Math.min(random.nextInt(1024 * 64), data.length - i); int length = Math.min(random.nextInt(1024 * 64), data.length - i);
ChannelFuture future = cc.write(Unpooled.wrappedBuffer(data, i, length)); ChannelFuture future = cc.write(Unpooled.wrappedBuffer(data, i, length));
// TODO: Remove me as it seems like ChunkWriteHandler has a bug which let it hang here
if (!chunkWriteHandler) {
future.sync(); future.sync();
}
i += length; i += length;
} }