From e09d2f32fb1c7f2ab8d1e41fdb72e00adb7032ff Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 28 Jul 2014 04:24:26 -0700 Subject: [PATCH] [#2708] DnsResource.duplicate() should return DnsResource and not ByteBufHolder Motivation: DnsResource.duplicate() should return DnsResource and not ByteBufHolder Modifications: Change return type from ByteBufHolder to DnsResource Result: No need to cast to the correct type when using duplicate() --- .../src/main/java/io/netty/handler/codec/dns/DnsResource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsResource.java b/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsResource.java index a6aa3106c9..968a149158 100644 --- a/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsResource.java +++ b/codec-dns/src/main/java/io/netty/handler/codec/dns/DnsResource.java @@ -74,7 +74,7 @@ public final class DnsResource extends DnsEntry implements ByteBufHolder { * Returns a duplicate of this resource record. */ @Override - public ByteBufHolder duplicate() { + public DnsResource duplicate() { return new DnsResource(name(), type(), dnsClass(), ttl, content.duplicate()); }