andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use ByteBuf.readSlice(...).retain() to minimize memory copies.

Browse Source 
Motivation:
At the moment we call ByteBuf.readBytes(...) in these handlers but with optimizations done as part of 25e0d9d we can just use readSlice(...).retain() and eliminate the memory copy.

Modifications:
Replace ByteBuf.readBytes(...) usage with readSlice(...).retain().

Result:
Less memory copies.
This commit is contained in:
Norman Maurer 2014-05-09 08:31:07 +02:00
parent dd0782990b
commit e26bbfd4a7
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java
View File

@ -268,13 +268,13 @@ public class DelimiterBasedFrameDecoder extends ByteToMessageDecoder {
}
if (stripDelimiter) {
frame = buffer.readBytes(minFrameLength);
frame = buffer.readSlice(minFrameLength);
buffer.skipBytes(minDelimLength);
} else {
frame = buffer.readBytes(minFrameLength + minDelimLength);
frame = buffer.readSlice(minFrameLength + minDelimLength);
}
return frame;
return frame.retain();
} else {
if (!discardingTooLongFrame) {
if (buffer.readableBytes() > maxFrameLength) {

2
codec/src/main/java/io/netty/handler/codec/FixedLengthFrameDecoder.java
View File

@ -74,7 +74,7 @@ public class FixedLengthFrameDecoder extends ByteToMessageDecoder {
if (in.readableBytes() < frameLength) {
return null;
} else {
return in.readBytes(frameLength);
return in.readSlice(frameLength).retain();
}
}
}

6
codec/src/main/java/io/netty/handler/codec/LineBasedFrameDecoder.java
View File

@ -100,13 +100,13 @@ public class LineBasedFrameDecoder extends ByteToMessageDecoder {
}
if (stripDelimiter) {
frame = buffer.readBytes(length);
frame = buffer.readSlice(length);
buffer.skipBytes(delimLength);
} else {
frame = buffer.readBytes(length + delimLength);
frame = buffer.readSlice(length + delimLength);
}
return frame;
return frame.retain();
} else {
final int length = buffer.readableBytes();
if (length > maxLength) {