andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unused parameter from method declaration.

Browse Source 
Motivation:

We had an unused paramter on a method, we should just remove it to keep code clean.

Modifications:

- Remove parameter
- Fix typo in javadoc

Result:

Cleanup done.
This commit is contained in:
Norman Maurer 2015-10-05 11:08:04 +02:00
parent 2f8bc24c62
commit e419533498
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java
View File

@ -255,7 +255,7 @@ public final class HttpConversionUtil {
* @param httpVersion What HTTP/1.x version {@code outputHeaders} should be treated as when doing the conversion. * @param httpVersion What HTTP/1.x version {@code outputHeaders} should be treated as when doing the conversion.
* @param isTrailer {@code true} if {@code outputHeaders} should be treated as trailing headers. * @param isTrailer {@code true} if {@code outputHeaders} should be treated as trailing headers.
* {@code false} otherwise. * {@code false} otherwise.
* @param isReqeust {@code true} if the {@code outputHeaders} will be used in a request message. * @param isRequest {@code true} if the {@code outputHeaders} will be used in a request message.
* {@code false} for response message. * {@code false} for response message.
* @throws Http2Exception If not all HTTP/2 headers can be translated to HTTP/1.x. * @throws Http2Exception If not all HTTP/2 headers can be translated to HTTP/1.x.
*/ */
@ -303,8 +303,7 @@ public final class HttpConversionUtil {
if (!isOriginForm(requestTargetUri) && !isAsteriskForm(requestTargetUri)) { if (!isOriginForm(requestTargetUri) && !isAsteriskForm(requestTargetUri)) {
// Attempt to take from HOST header before taking from the request-line // Attempt to take from HOST header before taking from the request-line
String host = inHeaders.getAsString(HttpHeaderNames.HOST); String host = inHeaders.getAsString(HttpHeaderNames.HOST);
setHttp2Authority(inHeaders, setHttp2Authority((host == null || host.isEmpty()) ? requestTargetUri.getAuthority() : host, out);
(host == null || host.isEmpty()) ? requestTargetUri.getAuthority() : host, out);
} }
} else if (in instanceof HttpResponse) { } else if (in instanceof HttpResponse) {
HttpResponse response = (HttpResponse) in; HttpResponse response = (HttpResponse) in;
@ -361,7 +360,7 @@ public final class HttpConversionUtil {
return path.isEmpty() ? EMPTY_REQUEST_PATH : new AsciiString(path); return path.isEmpty() ? EMPTY_REQUEST_PATH : new AsciiString(path);
} }
private static void setHttp2Authority(HttpHeaders in, String autority, Http2Headers out) { private static void setHttp2Authority(String autority, Http2Headers out) {
// The authority MUST NOT include the deprecated "userinfo" subcomponent // The authority MUST NOT include the deprecated "userinfo" subcomponent
if (autority != null) { if (autority != null) {
int endOfUserInfo = autority.indexOf('@'); int endOfUserInfo = autority.indexOf('@');